fix: CI workflow and release readiness bugs

- Swap pnpm/node setup order (pnpm must install before node cache)
- Move build step before E2E tests (next start needs .next/ output)
- Add `cp .env.test .env` step so E2E server has auth credentials
- Fix test:all script to build before E2E (same ordering bug)
- Remove stale package-lock.json (project uses pnpm exclusively)
- Update README: remove "No E2E test suite" (52 tests exist now)

.github/workflows/quality-gate.yml

@@ -16,23 +16,20 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10
+
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
           node-version: 20
           cache: 'pnpm'
 
-      - name: Setup pnpm
-        uses: pnpm/action-setup@v4
-        with:
-          version: 10
-
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
 
-      - name: Install Playwright browsers
-        run: pnpm exec playwright install --with-deps
-
       - name: Lint
         run: pnpm lint
 
@@ -42,8 +39,14 @@ jobs:
       - name: Unit tests
         run: pnpm test
 
-      - name: E2E tests
-        run: pnpm test:e2e
-
       - name: Build
         run: pnpm build
+
+      - name: Prepare E2E environment
+        run: cp .env.test .env
+
+      - name: Install Playwright browsers
+        run: pnpm exec playwright install --with-deps
+
+      - name: E2E tests
+        run: pnpm test:e2e

.gitignore

@@ -14,6 +14,9 @@ dist/
 *.pem
 .env*.local
 
+# npm (project uses pnpm)
+package-lock.json
+
 # Debug
 npm-debug.log*
 yarn-debug.log*

README.md

@@ -58,9 +58,8 @@ Initial login is seeded from `AUTH_USER` / `AUTH_PASS` on first run.
 
 ### Known Limitations
 
-- **Minimal test coverage** — Vitest unit test stubs and Playwright E2E config exist, but comprehensive tests are still needed
 - **CSP still includes `unsafe-inline`** — `unsafe-eval` has been removed, but inline styles remain for framework compatibility
-- **No E2E test suite** — Playwright is configured but no spec files exist yet
+- **Vitest stubs need real assertions** — unit test files exist but most are placeholder stubs
 
 ### Security Considerations
 
@@ -336,8 +335,7 @@ See [open issues](https://github.com/builderz-labs/mission-control/issues) for t
 
 #### Up Next
 
-- [ ] Comprehensive E2E test suite (Playwright)
-- [ ] Fill in Vitest test stubs with real assertions
+- [ ] Fill in Vitest unit test stubs with real assertions
 - [ ] API token rotation UI
 - [ ] Webhook signature verification
 

package.json

@@ -12,7 +12,7 @@
     "test:watch": "vitest",
     "test:ui": "vitest --ui",
     "test:e2e": "playwright test",
-    "test:all": "pnpm lint && pnpm typecheck && pnpm test && pnpm test:e2e && pnpm build",
+    "test:all": "pnpm lint && pnpm typecheck && pnpm test && pnpm build && pnpm test:e2e",
     "quality:gate": "pnpm test:all"
   },
   "dependencies": {