johan
/
mission-control
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ci): allow rate limit bypass in production test mode 

The E2E tests run the standalone server (NODE_ENV=production) but need
rate limiting disabled. Allow MC_DISABLE_RATE_LIMIT bypass when
MISSION_CONTROL_TEST_MODE=1 is also set, even in production.

Fixes 100 E2E failures (429 rate limited) in CI.
This commit is contained in:
Nyk 2026-03-21 23:53:40 +07:00
parent 666af416f9
commit 6fd1abf6fa
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/lib/rate-limit.ts
View File

@ -71,8 +71,9 @@ export function createRateLimiter(options: RateLimiterOptions) {
if (cleanupInterval.unref) cleanupInterval.unref() if (cleanupInterval.unref) cleanupInterval.unref()
return function checkRateLimit(request: Request): NextResponse | null { return function checkRateLimit(request: Request): NextResponse | null {
// Allow disabling non-critical rate limiting for E2E tests (never in production) // Allow disabling non-critical rate limiting for E2E tests
if (process.env.MC_DISABLE_RATE_LIMIT === '1' && !options.critical && process.env.NODE_ENV !== 'production') return null // In CI, standalone server runs with NODE_ENV=production but needs rate limit bypass
if (process.env.MC_DISABLE_RATE_LIMIT === '1' && !options.critical && (process.env.NODE_ENV !== 'production' || process.env.MISSION_CONTROL_TEST_MODE === '1')) return null
const ip = extractClientIp(request) const ip = extractClientIp(request)
const now = Date.now() const now = Date.now()
const entry = store.get(ip) const entry = store.get(ip)
@ -143,7 +144,7 @@ export function createAgentRateLimiter(options: RateLimiterOptions) {
if (cleanupInterval.unref) cleanupInterval.unref() if (cleanupInterval.unref) cleanupInterval.unref()
return function checkAgentRateLimit(request: Request): NextResponse | null { return function checkAgentRateLimit(request: Request): NextResponse | null {
if (process.env.MC_DISABLE_RATE_LIMIT === '1' && !options.critical && process.env.NODE_ENV !== 'production') return null if (process.env.MC_DISABLE_RATE_LIMIT === '1' && !options.critical && (process.env.NODE_ENV !== 'production' || process.env.MISSION_CONTROL_TEST_MODE === '1')) return null
const agentName = (request.headers.get('x-agent-name') || '').trim() const agentName = (request.headers.get('x-agent-name') || '').trim()
const key = agentName || `ip:${extractClientIp(request)}` const key = agentName || `ip:${extractClientIp(request)}`