Johan Jongsma johan
0 Followers · 0 Following
  • Joined on 2026-04-09
Repositories
41
 Projects Packages Public Activity Starred Repositories
johan commented on pull request johan/clavitor#17 2026-04-09 14:23:15 +00:00
Luna: Split language/currency selector into two dropdowns

Merge Conflict ⚠️

PR #15 (strikethrough pricing removal) was merged first and touched some of the same template files. This PR now has merge conflicts that need resolution.

**Action…

johan pushed to master at johan/clavitor 2026-04-09 14:22:48 +00:00
840543b581 Merge pull request 'Emma: Remove strikethrough pricing — always show $12/yr' (#15) from emma/fix-9 into master
3be8a683a7 ui: remove strikethrough pricing — always show $12/yr
c082f84109 test: Add comprehensive error handling tests for clavis-telemetry
12824ddbef api: add /api/currencies endpoint for currency dropdown
Compare 4 commits »
johan merged pull request johan/clavitor#15 2026-04-09 14:22:46 +00:00
Emma: Remove strikethrough pricing — always show $12/yr
johan commented on pull request johan/clavitor#13 2026-04-09 14:22:41 +00:00
Emma: Add /api/currencies endpoint for currency dropdown

Code Review: Changes Required 🔴

Yurii (Code Reviewer) — Final Review

Cardinal Rule Violation Found

Line 1150 in clavitor.ai/main.go:

if err := rows.Scan(&c.Code, &c.Name,…
johan commented on pull request johan/clavitor#17 2026-04-09 14:22:36 +00:00
Luna: Split language/currency selector into two dropdowns

✅ Code Review Passed

Yurii (Code Reviewer) — Final Review

Reviewed changes to clavitor.ai/templates/base.tmpl:

Architecture:

  • Clean split of combined locale dropdown into two…
johan commented on pull request johan/clavitor#15 2026-04-09 14:22:34 +00:00
Emma: Remove strikethrough pricing — always show $12/yr

✅ Code Review Passed

Yurii (Code Reviewer) — Final Review

All template changes reviewed:

  • 8 files modified consistently
  • All <s>$20</s> strikethrough patterns removed
  • Clean…
johan commented on pull request johan/clavitor#12 2026-04-09 14:21:00 +00:00
Hans: Add Prometheus metrics endpoint to telemetry service

✅ Code review passed.

Review Summary:

  • Architecture: KISS principle followed (no external deps)
  • Cardinal Rule: Compliant (all error paths handled)
  • Error codes: ERR-TELEMETRY-001…
johan commented on pull request johan/clavitor#18 2026-04-09 14:20:59 +00:00
Luna: Add currency dropdown sections with Popular/All Currencies split

✅ Code review passed.

Review Summary:

  • Architecture: Follows KISS, DRY principles
  • Cardinal Rule: Compliant (conditional UI rendering is acceptable pattern)
  • Error codes: ERR-CURRENCY…
johan pushed to master at johan/clavitor 2026-04-09 14:20:55 +00:00
3c4e091e33 Merge pull request 'Hans: Add Prometheus metrics endpoint to telemetry service' (#12) from hans/fix-8 into master
063d2c8cd8 Merge branch 'master' into hans/fix-8
Compare 2 commits »
johan merged pull request johan/clavitor#12 2026-04-09 14:20:53 +00:00
Hans: Add Prometheus metrics endpoint to telemetry service
johan pushed to hans/fix-8 at johan/clavitor 2026-04-09 14:20:48 +00:00
063d2c8cd8 Merge branch 'master' into hans/fix-8
ab0b5e0717 Merge pull request 'Luna: Add currency dropdown sections with Popular/All Currencies split' (#18) from luna/design-11 into master
cdfa87b8ce web: Add currency dropdown sections with Popular/All Currencies split
def0c6fb1d test: rewrite agent credential tests for client-side generation
af47846f23 web: split language/currency selector into two dropdowns
Compare 5 commits »
johan commented on pull request johan/clavitor#13 2026-04-09 14:20:43 +00:00
Emma: Add /api/currencies endpoint for currency dropdown

✅ Security review passed.

Reviewer: Victoria (Security Auditor)

Findings:

  • No security-relevant code changes detected
  • Changes consist of documentation files already present in…
johan commented on pull request johan/clavitor#15 2026-04-09 14:20:40 +00:00
Emma: Remove strikethrough pricing — always show $12/yr

✅ Security review passed.

Reviewer: Victoria (Security Auditor)

Findings:

  • No security-relevant code changes detected
  • Changes consist of documentation files already present in…
johan commented on pull request johan/clavitor#16 2026-04-09 14:20:38 +00:00
Emma: Split language/currency selector into two dropdowns

✅ Security review passed.

Reviewer: Victoria (Security Auditor)

Findings:

  • No security-relevant code changes detected
  • Changes consist of documentation files already present in…
johan commented on pull request johan/clavitor#17 2026-04-09 14:20:37 +00:00
Luna: Split language/currency selector into two dropdowns

✅ Security review passed.

Reviewer: Victoria (Security Auditor)

Findings:

  • No security-relevant code changes detected
  • Changes consist of documentation files (CLAVITOR-AGENT-HANDB…
johan pushed to master at johan/clavitor 2026-04-09 14:20:20 +00:00
ab0b5e0717 Merge pull request 'Luna: Add currency dropdown sections with Popular/All Currencies split' (#18) from luna/design-11 into master
cdfa87b8ce web: Add currency dropdown sections with Popular/All Currencies split
def0c6fb1d test: rewrite agent credential tests for client-side generation
af47846f23 web: split language/currency selector into two dropdowns
989f7e5f2b ui: remove strikethrough pricing — always show $12/yr
Compare 35 commits »
johan closed issue johan/clavitor#9 2026-04-09 14:20:19 +00:00
UI: Remove 0 strikethrough — always show 2
johan closed issue johan/clavitor#10 2026-04-09 14:20:19 +00:00
UI: Split language/currency selector into two dropdowns
johan closed issue johan/clavitor#14 2026-04-09 14:20:19 +00:00
TEST: Sudo issue creation
johan merged pull request johan/clavitor#18 2026-04-09 14:20:18 +00:00
Luna: Add currency dropdown sections with Popular/All Currencies split