Yurii: clavis-telemetry missing unique error codes (Cardinal Rule #1) #1

New Issue

johan · 2026-04-09T04:45:56Z

johan commented

2026-04-09 04:45:56 +00:00

Violation

Per CLAVITOR-AGENT-HANDBOOK.md Part 1:

Mandatory error handling with unique codes:

Use unique error codes: ToLog("ERR-12345: L3 unavailable in decrypt")

Locations

clavis/clavis-telemetry/main.go:

Line 41: log.Fatalf("Failed to open operations.db: %v", err) — no ERR-XXXXX code
Line 47: log.Fatalf("Failed to load CA chain for mTLS: %v", err) — no ERR-XXXXX code
Line 228: log.Printf("Invalid certificate from %s: %v", popID, err) — no ERR-XXXXX code
Lines 337, 342-351, 367-370: OUTAGE SPAN logs — no ERR-XXXXX codes
Lines 383, 395, 398: ntfy error logs — no ERR-XXXXX codes

clavis/clavis-telemetry/kuma.go:

Line 56-58: Silent fail on Kuma push — no error code, no logging

Required Fix

Assign unique error codes for each error path: ERR-TELEMETRY-001 through ERR-TELEMETRY-020
Format: ERR-TELEMETRY-XXX: <actionable message>
Include error codes in all fatal logs, certificate failures, external alerting failures

Assignment

Domain: clavis-telemetry
Domain Owner: Hans (per Section I agent mapping)
Priority: Medium
Review by: Yurii (after fix)

## Violation Per CLAVITOR-AGENT-HANDBOOK.md Part 1: > Mandatory error handling with unique codes: > - Use unique error codes: `ToLog("ERR-12345: L3 unavailable in decrypt")` ## Locations **clavis/clavis-telemetry/main.go:** - Line 41: `log.Fatalf("Failed to open operations.db: %v", err)` — no ERR-XXXXX code - Line 47: `log.Fatalf("Failed to load CA chain for mTLS: %v", err)` — no ERR-XXXXX code - Line 228: `log.Printf("Invalid certificate from %s: %v", popID, err)` — no ERR-XXXXX code - Lines 337, 342-351, 367-370: OUTAGE SPAN logs — no ERR-XXXXX codes - Lines 383, 395, 398: ntfy error logs — no ERR-XXXXX codes **clavis/clavis-telemetry/kuma.go:** - Line 56-58: Silent fail on Kuma push — no error code, no logging ## Required Fix 1. Assign unique error codes for each error path: `ERR-TELEMETRY-001` through `ERR-TELEMETRY-020` 2. Format: `ERR-TELEMETRY-XXX: <actionable message>` 3. Include error codes in all fatal logs, certificate failures, external alerting failures ## Assignment - Domain: clavis-telemetry - Domain Owner: Hans (per Section I agent mapping) - Priority: Medium - Review by: Yurii (after fix)

hans was assigned by johan

2026-04-09 05:41:49 +00:00

johan closed this issue

2026-04-09 06:34:02 +00:00

johan referenced this issue from a commit

2026-04-09 07:16:12 +00:00

telemetry: fix CRITICAL silent failures (Cardinal Rule #1)

johan referenced this issue

2026-04-09 07:16:18 +00:00

Hans: Verify dispatcher agent spawning for clavis-telemetry (Issue #5) #6

Sign in to join this conversation.